Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.cpp

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLInputElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
index 7bc8ce32edf96d7f0dc0f33abc20541cbb69fab4..8642efce92e9f48d25823d94c16738ebd327937d 100644
--- a/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.cpp
@@ -1091,8 +1091,9 @@ void HTMLInputElement::setValue(const String& value,
notifyFormStateChanged();
}
-void HTMLInputElement::setValueInternal(const String& sanitizedValue,
- TextFieldEventBehavior eventBehavior) {
+void HTMLInputElement::setNonAttributeValue(const String& sanitizedValue) {
+ // This is a common code for ValueMode::kValue.
+ DCHECK_EQ(m_inputType->valueMode(), ValueMode::kValue);
m_valueIfDirty = sanitizedValue;
m_hasDirtyValue = !m_valueIfDirty.isNull();
setNeedsValidityCheck();
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLInputElement.h ('k') | third_party/WebKit/Source/core/html/forms/ColorInputType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698