Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
index 410a938a5bad3b798164b19c5e31607cfeae8d20..db8b288d970ae1108321a111586f3792a814b87a 100644
--- a/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/TextFieldInputType.cpp
@@ -148,9 +148,9 @@ bool TextFieldInputType::canSetSuggestedValue() {
void TextFieldInputType::setValue(const String& sanitizedValue,
bool valueChanged,
TextFieldEventBehavior eventBehavior) {
- // We don't ask InputType::setValue to dispatch events because
- // TextFieldInputType dispatches events different way from InputType.
- InputType::setValue(sanitizedValue, valueChanged, DispatchNoEvent);
+ // We don't use InputType::setValue. TextFieldInputType dispatches events
+ // different way from InputType::setValue.
+ element().setNonAttributeValue(sanitizedValue);
if (valueChanged)
element().updateView();
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698