INPUT element: code cleanup around setValue().

third_party/WebKit/Source/core/html/forms/InputType.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All
  * rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2009, 2010, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 495 matching lines @@
 bool InputType::shouldDispatchFormControlChangeEvent(String& oldValue,
                                                      String& newValue) {
   return !equalIgnoringNullity(oldValue, newValue);
 }
 
 void InputType::dispatchSearchEvent() {}
 
 void InputType::setValue(const String& sanitizedValue,
                          bool valueChanged,
                          TextFieldEventBehavior eventBehavior) {
-  element().setValueInternal(sanitizedValue, eventBehavior);
+  // This setValue() implementation is used only for ValueMode::kValue except
+  // TextFieldInputType. That is to say, type=color, type=range, and temporal
+  // input types.
+  DCHECK_EQ(valueMode(), ValueMode::kValue);
+  element().setNonAttributeValue(sanitizedValue);
   if (!valueChanged)
     return;
   switch (eventBehavior) {
     case DispatchChangeEvent:
       element().dispatchFormControlChangeEvent();
       break;
     case DispatchInputAndChangeEvent:
       element().dispatchFormControlInputEvent();
       element().dispatchFormControlChangeEvent();
       break;
@@ skipping 371 matching lines @@
 
 void InputType::addWarningToConsole(const char* messageFormat,
                                     const String& value) const {
   element().document().addConsoleMessage(ConsoleMessage::create(
       RenderingMessageSource, WarningMessageLevel,
       String::format(messageFormat,
                      JSONValue::quoteString(value).utf8().data())));
 }
 
 }  // namespace blink