third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp - Issue 2435973002: INPUT element: code cleanup around setValue().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

Issue 2435973002: INPUT element: code cleanup around setValue(). (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/forms/InputType.cpp ('k') | third_party/WebKit/Source/core/html/forms/RangeInputType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp b/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

index 5cf87fcad2864467947781410e5b890001e6fc52..daf8bad72a409ef8364d293ea19162fa7ca6ae0d 100644

--- a/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

+++ b/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

@@ -194,7 +194,7 @@ void MultipleFieldsTemporalInputTypeView::editControlValueChanged() {

if ((oldValue.isEmpty() && newValue.isEmpty()) || oldValue == newValue) {

element().setNeedsValidityCheck();

} else {

- element().setValueInternal(newValue, DispatchNoEvent);

+ element().setNonAttributeValue(newValue);

element().setNeedsStyleRecalc(

SubtreeStyleChange,

StyleChangeReasonForTracing::create(StyleChangeReason::ControlValue));

@@ -482,8 +482,7 @@ void MultipleFieldsTemporalInputTypeView::restoreFormControlState(

DateTimeFieldsState dateTimeFieldsState =

DateTimeFieldsState::restoreFormControlState(state);

edit->setValueAsDateTimeFieldsState(dateTimeFieldsState);

- element().setValueInternal(m_inputType->sanitizeValue(edit->value()),

- DispatchNoEvent);

+ element().setNonAttributeValue(m_inputType->sanitizeValue(edit->value()));

updateClearButtonVisibility();

}