Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed)

Created:
6 years, 8 months ago by limasdf
Modified:
6 years, 8 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, sadrul, tzik, markusheintz_, aandrey+blink_chromium.org, kinuko+watch, extensions-reviews_chromium.org, vsevik, chromoting-reviews_chromium.org, devtools-reviews_chromium.org, kalyank, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, nhiroki, paulirish+reviews_chromium.org, pam+watch_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, tfarina, yurys, pfeldman, estade+watch_chromium.org, James Su, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED to have bidirect with NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED. This CL is the result of below script, and 'git cl format'. find -regex '.*/.*\.\(mm\|cc\|h\)$' | xargs sed -i s/NOTIFICATION_EXTENSION_LOADED/NOTIFICATION_EXTENSION_LOADED_DEPRECATED/g BUG=354367 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264939

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and address review comment. #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -183 lines) Patch
M apps/app_window_geometry_cache.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/shell/browser/shell_extension_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/extension_app_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background/background_application_list_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/background/background_contents_service.cc View 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/background/background_mode_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_notification_types.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_sanity_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/alarms/alarm_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 2 chunks +7 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/location/location_manager.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_api.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/runtime/runtime_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/spellcheck/spellcheck_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_disabled_ui.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_functional_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_gcm_app_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_notification_observer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_test_notification_observer.cc View 1 2 chunks +28 lines, -28 lines 0 comments Download
M chrome/browser/extensions/extension_toolbar_model.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_web_ui_override_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_install_ui.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/install_tracker.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/infobars/infobars_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/managed_mode/managed_user_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/themes/theme_service_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/app_sync_ui_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/extension_enable_flow.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/extension_installed_bubble.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/command_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/uber/uber_ui.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/event_router.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/process_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/process_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
limasdf
mechanical change. PTAL.
6 years, 8 months ago (2014-04-18 07:55:24 UTC) #1
sky
LGTM https://codereview.chromium.org/242613004/diff/1/chrome/browser/extensions/extension_test_notification_observer.cc File chrome/browser/extensions/extension_test_notification_observer.cc (right): https://codereview.chromium.org/242613004/diff/1/chrome/browser/extensions/extension_test_notification_observer.cc#newcode256 chrome/browser/extensions/extension_test_notification_observer.cc:256: case chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED: If you're going to change this ...
6 years, 8 months ago (2014-04-18 14:11:48 UTC) #2
limasdf
@sky, Thanks for the review! @kalman, I'll TBR from you.(already lgtm from sky) https://codereview.chromium.org/242613004/diff/1/chrome/browser/extensions/extension_test_notification_observer.cc File ...
6 years, 8 months ago (2014-04-18 14:22:58 UTC) #3
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-18 14:23:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/242613004/20001
6 years, 8 months ago (2014-04-18 14:23:19 UTC) #5
not at google - send to devlin
thanks! (lgtm to not block cq, I didn't actually look at the change)
6 years, 8 months ago (2014-04-18 15:21:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 15:58:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_compile_dbg
6 years, 8 months ago (2014-04-18 15:58:46 UTC) #8
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-18 16:16:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/242613004/40001
6 years, 8 months ago (2014-04-18 16:16:46 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-18 22:40:20 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-18 22:40:21 UTC) #12
limasdf
The CQ bit was checked by limasdf@gmail.com
6 years, 8 months ago (2014-04-19 02:41:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/limasdf@gmail.com/242613004/40001
6 years, 8 months ago (2014-04-19 02:41:11 UTC) #14
commit-bot: I haz the power
6 years, 8 months ago (2014-04-20 21:54:46 UTC) #15
Message was sent while issue was closed. 
Change committed as 264939

Powered by Google App Engine
This is Rietveld 408576698