chrome/browser/extensions/extension_toolbar_model.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_test_notification_observer.cc ('k') | chrome/browser/extensions/extension_web_ui_override_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_toolbar_model.cc

diff --git a/chrome/browser/extensions/extension_toolbar_model.cc b/chrome/browser/extensions/extension_toolbar_model.cc

index 878a23dedc71cc1c71c683b17b18fe87b69bd91c..74e8280992a878c0df0072d31c4e260259126eb2 100644

--- a/chrome/browser/extensions/extension_toolbar_model.cc

+++ b/chrome/browser/extensions/extension_toolbar_model.cc

@@ -48,7 +48,8 @@ ExtensionToolbarModel::ExtensionToolbarModel(

extensions_initialized_(false),

is_highlighting_(false),

weak_ptr_factory_(this) {

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,

+ registrar_.Add(this,

+ chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

content::Source<Profile>(profile_));

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

content::Source<Profile>(profile_));

@@ -204,7 +205,7 @@ void ExtensionToolbarModel::Observe(

} else {

extension = content::Details<const Extension>(details).ptr();

}

- if (type == chrome::NOTIFICATION_EXTENSION_LOADED) {

+ if (type == chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED) {

// We don't want to add the same extension twice. It may have already been

// added by EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED below, if the user

// hides the browser action and then disables and enables the extension.