chrome/browser/extensions/extension_service.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_notification_observer.cc ('k') | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 5ab5f6f2509c671acb62c0f9c917536b26a5b7d2..3d6588aa693a240163f6edcae06e96807f8b8ab0 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1018,12 +1018,13 @@ void ExtensionService::NotifyExtensionLoaded(const Extension* extension) {

// NOTE: It is important that this happen after notifying the renderers about

// the new extensions so that if we navigate to an extension URL in

- // ExtensionRegistryObserver::OnLoaded or NOTIFICATION_EXTENSION_LOADED, the

+ // ExtensionRegistryObserver::OnLoaded or

+ // NOTIFICATION_EXTENSION_LOADED_DEPRECATED, the

// renderer is guaranteed to know about it.

registry_->TriggerOnLoaded(extension);

content::NotificationService::current()->Notify(

- chrome::NOTIFICATION_EXTENSION_LOADED,

+ chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

content::Source<Profile>(profile_),

content::Details<const Extension>(extension));