chrome/browser/extensions/api/extension_action/extension_action_api.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/file_system/file_system_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/extension_action_api.cc

diff --git a/chrome/browser/extensions/api/extension_action/extension_action_api.cc b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

index 4925b68e5dff9ee7924bf172a2db99535890de98..02ef495c955660dc63bcc1d69b5bc04eb2a267a2 100644

--- a/chrome/browser/extensions/api/extension_action/extension_action_api.cc

+++ b/chrome/browser/extensions/api/extension_action/extension_action_api.cc

@@ -416,7 +416,8 @@ void ExtensionActionAPI::ExtensionActionExecuted(

ExtensionActionStorageManager::ExtensionActionStorageManager(Profile* profile)

: profile_(profile) {

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,

+ registrar_.Add(this,

+ chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

content::Source<Profile>(profile_));

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_UPDATED,

content::NotificationService::AllBrowserContextsAndSources());

@@ -434,7 +435,7 @@ void ExtensionActionStorageManager::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

switch (type) {

- case chrome::NOTIFICATION_EXTENSION_LOADED: {

+ case chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED: {

const Extension* extension =

content::Details<const Extension>(details).ptr();

if (!ExtensionActionManager::Get(profile_)->