chrome/browser/extensions/external_install_ui.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_ui.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_web_ui_override_registrar.cc ('k') | chrome/browser/extensions/install_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_install_ui.cc

diff --git a/chrome/browser/extensions/external_install_ui.cc b/chrome/browser/extensions/external_install_ui.cc

index 665b1e1aa8dc59945f01443c19f7d1e9808052ae..82586fccd8c92b547a436a04a8878186ed50b161 100644

--- a/chrome/browser/extensions/external_install_ui.cc

+++ b/chrome/browser/extensions/external_install_ui.cc

@@ -340,7 +340,8 @@ ExternalInstallMenuAlert::ExternalInstallMenuAlert(

const Extension* extension)

: service_(service),

extension_(extension) {

- registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_LOADED,

+ registrar_.Add(this,

+ chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

content::Source<Profile>(service->profile()));

registrar_.Add(this, chrome::NOTIFICATION_EXTENSION_REMOVED,

content::Source<Profile>(service->profile()));

@@ -414,7 +415,7 @@ void ExternalInstallMenuAlert::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

// The error is invalidated if the extension has been loaded or removed.

- DCHECK(type == chrome::NOTIFICATION_EXTENSION_LOADED ||

+ DCHECK(type == chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED ||

type == chrome::NOTIFICATION_EXTENSION_REMOVED);

const Extension* extension = content::Details<const Extension>(details).ptr();

if (extension != extension_)

« no previous file with comments | « chrome/browser/extensions/extension_web_ui_override_registrar.cc ('k') | chrome/browser/extensions/install_tracker.cc » ('j') | no next file with comments »