chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 242613004: Replace NOTIFICATION_EXTENSION_LOADED to NOTIFICATION_EXTENSION_LOADED_DEPRECATED (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/rules_registry_service.cc ('k') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index 3c79ed8fe10d0be8192f4477f54cb9e69f169b40..1676b1acbc650401ce099c3399bba7dc11327aac 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -173,14 +173,12 @@ DeveloperPrivateAPI::DeveloperPrivateAPI(content::BrowserContext* context)

DeveloperPrivateEventRouter::DeveloperPrivateEventRouter(Profile* profile)

: profile_(profile) {

- int types[] = {

- chrome::NOTIFICATION_EXTENSION_INSTALLED,

- chrome::NOTIFICATION_EXTENSION_UNINSTALLED,

- chrome::NOTIFICATION_EXTENSION_LOADED,

- chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

- chrome::NOTIFICATION_EXTENSION_VIEW_REGISTERED,

- chrome::NOTIFICATION_EXTENSION_VIEW_UNREGISTERED

- };

+ int types[] = {chrome::NOTIFICATION_EXTENSION_INSTALLED,

+ chrome::NOTIFICATION_EXTENSION_UNINSTALLED,

+ chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,

+ chrome::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED,

+ chrome::NOTIFICATION_EXTENSION_VIEW_REGISTERED,

+ chrome::NOTIFICATION_EXTENSION_VIEW_UNREGISTERED};

CHECK(registrar_.IsEmpty());

for (size_t i = 0; i < arraysize(types); ++i) {

@@ -227,7 +225,7 @@ void DeveloperPrivateEventRouter::Observe(

event_data.event_type = developer::EVENT_TYPE_UNINSTALLED;

extension = content::Details<const Extension>(details).ptr();

break;

- case chrome::NOTIFICATION_EXTENSION_LOADED:

+ case chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED:

event_data.event_type = developer::EVENT_TYPE_LOADED;

extension = content::Details<const Extension>(details).ptr();

break;