Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Created:
4 years, 2 months ago by skym
Modified:
4 years, 2 months ago
Reviewers:
maxbogue
CC:
chromium-reviews, cbentzel+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. BUG=656689 Committed: https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177 Cr-Commit-Position: refs/heads/master@{#425761}

Patch Set 1 #

Patch Set 2 : Fixing compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -289 lines) Patch
M chrome/browser/sync/chrome_sync_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc View 2 chunks +10 lines, -13 lines 0 comments Download
M chrome/browser/sync/sync_error_notifier_ash_unittest.cc View 1 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/sync/sync_startup_tracker_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/sync_arc_package_helper.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M components/browser_sync/abstract_profile_sync_service_test.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M components/browser_sync/profile_sync_service_autofill_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/browser_sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/browser_sync/profile_sync_service_startup_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/browser_sync/profile_sync_service_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/base/cryptographer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M components/sync/base/proto_value_ptr_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/sync/device_info/device_info_data_type_controller_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/device_info/device_info_sync_service_unittest.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M components/sync/device_info/local_device_info_provider_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/device_info/local_device_info_provider_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/device_info/local_device_info_provider_mock.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/sync/driver/backend_migrator_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/driver/data_type_manager_impl_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/sync/driver/frontend_data_type_controller_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/driver/generic_change_processor.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/sync/driver/generic_change_processor_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M components/sync/driver/glue/sync_backend_registrar.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/driver/glue/sync_backend_registrar_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M components/sync/driver/model_type_controller_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/shared_change_processor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/driver/startup_controller_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/engine/attachments/fake_attachment_downloader.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M components/sync/engine/attachments/on_disk_attachment_store.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/engine/fake_sync_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine/net/http_bridge.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/sync/engine_impl/apply_control_data_updates_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine_impl/attachments/attachment_downloader_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/engine_impl/attachments/attachment_downloader_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine_impl/attachments/attachment_uploader_impl_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M components/sync/engine_impl/cycle/sync_cycle.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine_impl/directory_update_handler.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M components/sync/engine_impl/directory_update_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/engine_impl/model_type_registry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/model_type_registry_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/engine_impl/model_type_worker_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M components/sync/engine_impl/sync_encryption_handler_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M components/sync/engine_impl/sync_scheduler_impl_unittest.cc View 2 chunks +11 lines, -10 lines 0 comments Download
M components/sync/engine_impl/syncer_unittest.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M components/sync/engine_impl/syncer_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine_impl/worker_entity_tracker.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/sync/model/attachments/attachment_service_proxy_unittest.cc View 2 chunks +36 lines, -31 lines 0 comments Download
M components/sync/model/fake_model_type_service.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/sync/model/sync_error.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/model_impl/attachments/attachment_service_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/model_impl/attachments/attachment_service_impl_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/model_impl/attachments/task_queue.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/sync/model_impl/attachments/task_queue_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync/model_impl/model_type_store_backend_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/model_impl/model_type_store_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/shared_model_type_processor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/syncable/directory_backing_store.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/syncable/directory_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M components/sync/syncable/syncable_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/sync/syncable/test_user_share.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M components/sync/test/engine/test_directory_setter_upper.cc View 3 chunks +9 lines, -6 lines 0 comments Download
M components/sync/tools/sync_client.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M components/sync/tools/sync_listen_notifications.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_bookmarks/bookmark_data_type_controller_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M components/sync_sessions/session_data_type_controller_unittest.cc View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
skym
PTAL
4 years, 2 months ago (2016-10-17 18:47:27 UTC) #8
maxbogue
lgtm
4 years, 2 months ago (2016-10-17 19:04:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422253002/20001
4 years, 2 months ago (2016-10-17 19:10:06 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-17 20:08:46 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 20:11:53 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc10e451dad389a56e8fd16f8125eed397387177
Cr-Commit-Position: refs/heads/master@{#425761}

Powered by Google App Engine
This is Rietveld 408576698