components/sync/model/fake_model_type_service.cc - Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/fake_model_type_service.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Patch Set: Fixing compile. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/fake_model_type_service.cc

diff --git a/components/sync/model/fake_model_type_service.cc b/components/sync/model/fake_model_type_service.cc

index 6eb0b56451a6040ecc3f77893fc5472027634d98..78d60263729915c7787364568147fb7ddf269436 100644

--- a/components/sync/model/fake_model_type_service.cc

+++ b/components/sync/model/fake_model_type_service.cc

@@ -307,7 +307,8 @@ ConflictResolution FakeModelTypeService::ResolveConflict(

void FakeModelTypeService::SetConflictResolution(

ConflictResolution resolution) {

- conflict_resolution_.reset(new ConflictResolution(std::move(resolution)));

+ conflict_resolution_ =

+ base::MakeUnique<ConflictResolution>(std::move(resolution));

}

void FakeModelTypeService::SetServiceError(SyncError::ErrorType error_type) {