components/sync/engine_impl/directory_update_handler_unittest.cc - Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/engine_impl/directory_update_handler_unittest.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Patch Set: Fixing compile. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/engine_impl/directory_update_handler_unittest.cc

diff --git a/components/sync/engine_impl/directory_update_handler_unittest.cc b/components/sync/engine_impl/directory_update_handler_unittest.cc

index 4dde95ac1e7103825d51431afbdba544c54f02ad..f400278b21cac87a6a983f2c0bdf92b4614b63ba 100644

--- a/components/sync/engine_impl/directory_update_handler_unittest.cc

+++ b/components/sync/engine_impl/directory_update_handler_unittest.cc

@@ -477,7 +477,7 @@ class DirectoryUpdateHandlerApplyUpdateTest : public ::testing::Test {

void SetUp() override {

dir_maker_.SetUp();

- entry_factory_.reset(new TestEntryFactory(directory()));

+ entry_factory_ = base::MakeUnique<TestEntryFactory>(directory());

update_handler_map_.insert(std::make_pair(

BOOKMARKS,