components/sync/driver/glue/sync_backend_host_core.cc - Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/glue/sync_backend_host_core.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Patch Set: Fixing compile. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/glue/sync_backend_host_core.cc

diff --git a/components/sync/driver/glue/sync_backend_host_core.cc b/components/sync/driver/glue/sync_backend_host_core.cc

index 8c3e250ad7e4362dd6f01350c667394b536c8f29..48f0afa347c2bb21eae10990cb76d2b98c993dc7 100644

--- a/components/sync/driver/glue/sync_backend_host_core.cc

+++ b/components/sync/driver/glue/sync_backend_host_core.cc

@@ -655,7 +655,7 @@ void SyncBackendHostCore::StartSavingChanges() {

return;

DCHECK(sync_loop_->task_runner()->BelongsToCurrentThread());

DCHECK(!save_changes_timer_.get());

- save_changes_timer_.reset(new base::RepeatingTimer());

+ save_changes_timer_ = base::MakeUnique<base::RepeatingTimer>();

save_changes_timer_->Start(

FROM_HERE, base::TimeDelta::FromSeconds(kSaveChangesIntervalSeconds),

this, &SyncBackendHostCore::SaveChanges);