chrome/browser/sync/profile_sync_service_android.cc - Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_android.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)

Patch Set: Fixing compile. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/profile_sync_service_android.cc

diff --git a/chrome/browser/sync/profile_sync_service_android.cc b/chrome/browser/sync/profile_sync_service_android.cc

index cb6df2f31c46837e4bf46aba424e40170a47e8a8..d6ea80978358f8c29eebcfe8b205fd84d3821e4d 100644

--- a/chrome/browser/sync/profile_sync_service_android.cc

+++ b/chrome/browser/sync/profile_sync_service_android.cc

@@ -97,7 +97,7 @@ ProfileSyncServiceAndroid::ProfileSyncServiceAndroid(JNIEnv* env, jobject obj)

return;

}

- sync_prefs_.reset(new syncer::SyncPrefs(profile_->GetPrefs()));

+ sync_prefs_ = base::MakeUnique<syncer::SyncPrefs>(profile_->GetPrefs());

sync_service_ =

ProfileSyncServiceFactory::GetInstance()->GetForProfile(profile_);