Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: components/sync_sessions/session_data_type_controller_unittest.cc

Issue 2422253002: [Sync] Rewriting ".reset(new" pattern to use "= base::MakeUnique" instead. (Closed)
Patch Set: Fixing compile. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync_bookmarks/bookmark_data_type_controller_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_sessions/session_data_type_controller.h" 5 #include "components/sync_sessions/session_data_type_controller.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/files/file_path.h" 11 #include "base/files/file_path.h"
12 #include "base/memory/ptr_util.h"
12 #include "base/memory/weak_ptr.h" 13 #include "base/memory/weak_ptr.h"
13 #include "base/message_loop/message_loop.h" 14 #include "base/message_loop/message_loop.h"
14 #include "base/run_loop.h" 15 #include "base/run_loop.h"
15 #include "base/threading/thread_task_runner_handle.h" 16 #include "base/threading/thread_task_runner_handle.h"
16 #include "components/prefs/pref_registry_simple.h" 17 #include "components/prefs/pref_registry_simple.h"
17 #include "components/prefs/testing_pref_service.h" 18 #include "components/prefs/testing_pref_service.h"
18 #include "components/sync/device_info/local_device_info_provider_mock.h" 19 #include "components/sync/device_info/local_device_info_provider_mock.h"
19 #include "components/sync/driver/fake_sync_client.h" 20 #include "components/sync/driver/fake_sync_client.h"
20 #include "components/sync/driver/sync_api_component_factory_mock.h" 21 #include "components/sync/driver/sync_api_component_factory_mock.h"
21 #include "components/sync_sessions/fake_sync_sessions_client.h" 22 #include "components/sync_sessions/fake_sync_sessions_client.h"
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 PrefService* GetPrefService() override { return &prefs_; } 108 PrefService* GetPrefService() override { return &prefs_; }
108 109
109 SyncSessionsClient* GetSyncSessionsClient() override { 110 SyncSessionsClient* GetSyncSessionsClient() override {
110 return sync_sessions_client_.get(); 111 return sync_sessions_client_.get();
111 } 112 }
112 113
113 void SetUp() override { 114 void SetUp() override {
114 prefs_.registry()->RegisterBooleanPref(kSavingBrowserHistoryDisabled, 115 prefs_.registry()->RegisterBooleanPref(kSavingBrowserHistoryDisabled,
115 false); 116 false);
116 117
117 synced_window_delegate_.reset(new MockSyncedWindowDelegate()); 118 synced_window_delegate_ = base::MakeUnique<MockSyncedWindowDelegate>();
118 synced_window_getter_.reset(new MockSyncedWindowDelegatesGetter()); 119 synced_window_getter_ = base::MakeUnique<MockSyncedWindowDelegatesGetter>();
119 sync_sessions_client_.reset(new TestSyncSessionsClient()); 120 sync_sessions_client_ = base::MakeUnique<TestSyncSessionsClient>();
120 synced_window_getter_->Add(synced_window_delegate_.get()); 121 synced_window_getter_->Add(synced_window_delegate_.get());
121 sync_sessions_client_->SetSyncedWindowDelegatesGetter( 122 sync_sessions_client_->SetSyncedWindowDelegatesGetter(
122 synced_window_getter_.get()); 123 synced_window_getter_.get());
123 124
124 local_device_.reset(new LocalDeviceInfoProviderMock( 125 local_device_ = base::MakeUnique<LocalDeviceInfoProviderMock>(
125 "cache_guid", "Wayne Gretzky's Hacking Box", "Chromium 10k", 126 "cache_guid", "Wayne Gretzky's Hacking Box", "Chromium 10k",
126 "Chrome 10k", sync_pb::SyncEnums_DeviceType_TYPE_LINUX, "device_id")); 127 "Chrome 10k", sync_pb::SyncEnums_DeviceType_TYPE_LINUX, "device_id");
127 128
128 controller_.reset(new SessionDataTypeController( 129 controller_ = base::MakeUnique<SessionDataTypeController>(
129 base::Bind(&base::DoNothing), this, local_device_.get(), 130 base::Bind(&base::DoNothing), this, local_device_.get(),
130 kSavingBrowserHistoryDisabled)); 131 kSavingBrowserHistoryDisabled);
131 132
132 load_finished_ = false; 133 load_finished_ = false;
133 last_type_ = syncer::UNSPECIFIED; 134 last_type_ = syncer::UNSPECIFIED;
134 last_error_ = syncer::SyncError(); 135 last_error_ = syncer::SyncError();
135 } 136 }
136 137
137 void Start() { 138 void Start() {
138 controller_->LoadModels( 139 controller_->LoadModels(
139 base::Bind(&SessionDataTypeControllerTest::OnLoadFinished, 140 base::Bind(&SessionDataTypeControllerTest::OnLoadFinished,
140 base::Unretained(this))); 141 base::Unretained(this)));
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 EXPECT_EQ(syncer::DataTypeController::MODEL_STARTING, controller()->state()); 253 EXPECT_EQ(syncer::DataTypeController::MODEL_STARTING, controller()->state());
253 254
254 local_device()->SetInitialized(true); 255 local_device()->SetInitialized(true);
255 EXPECT_EQ(syncer::DataTypeController::MODEL_LOADED, controller()->state()); 256 EXPECT_EQ(syncer::DataTypeController::MODEL_LOADED, controller()->state());
256 EXPECT_TRUE(LoadResult()); 257 EXPECT_TRUE(LoadResult());
257 } 258 }
258 259
259 } // namespace 260 } // namespace
260 261
261 } // namespace sync_sessions 262 } // namespace sync_sessions
OLDNEW
« no previous file with comments | « components/sync_bookmarks/bookmark_data_type_controller_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698