Fix chrome_java FindBugs errors found when switching to n sdk.

Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent, String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side effect is ignored
  In class org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object, Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG=623989
Committed: https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477
Cr-Commit-Position: refs/heads/master@{#425384}

[agrieve, 2016-10-14 01:04:55]

agrieve@chromium.org changed reviewers:
+ tedchoc@chromium.org

[agrieve, 2016-10-14 01:05:02]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-10-14 01:55:10]

Description was changed from

==========
Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method
org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method
org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not
discharged
  Path continues at ShareHelper.java:[line 399]

BUG=623989
==========

to

==========
Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method
org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method
org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not
discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent,
String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not
discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side
effect is ignored
  In class
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object,
Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG=623989
==========

[agrieve, 2016-10-14 01:55:52]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 01:56:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 03:12:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 03:12:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[agrieve, 2016-10-14 13:55:52]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 13:56:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 13:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 13:58:20]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[agrieve, 2016-10-14 15:28:11]

agrieve@chromium.org changed reviewers:
+ gsennton@chromium.org, mariakhomenko@chromium.org

[agrieve, 2016-10-14 15:28:25]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-14 15:28:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2016-10-14 15:31:44]

On 2016/10/14 01:04:56, agrieve wrote:

+gsennton & Maria since I see you've just changed CrashFileManager recently.

[commit-bot: I haz the power, 2016-10-14 16:00:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-14 16:00:03]

Dry run: This issue passed the CQ dry run.

[Ted C, 2016-10-14 16:12:26]

lgtm but I didn't look at the crash changes as I'll defer to people that have
looked at that code recently

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(left):

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:400:
fOut.flush();
i guess the flush here wasn't actually needed?  i would expect close to do that
internally, so it makes sense to me

[Alexei Svitkine (slow), 2016-10-14 16:15:06]

asvitkine@chromium.org changed reviewers:
+ isherman@chromium.org

[Alexei Svitkine (slow), 2016-10-14 16:15:07]

+isherman for crash stuff as well

[Maria, 2016-10-14 17:06:10]

lgtm

[agrieve, 2016-10-14 17:47:15]

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(left):

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:400:
fOut.flush();
On 2016/10/14 16:12:26, Ted C wrote:
> i guess the flush here wasn't actually needed?  i would expect close to do
that
> internally, so it makes sense to me

Right - close() flush()es.

[agrieve, 2016-10-14 17:47:24]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-10-14 17:48:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 17:55:16]

Description was changed from

==========
Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method
org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method
org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not
discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent,
String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not
discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side
effect is ignored
  In class
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object,
Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG=623989
==========

to

==========
Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method
org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method
org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not
discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent,
String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not
discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side
effect is ignored
  In class
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object,
Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG=623989
==========

[commit-bot: I haz the power, 2016-10-14 17:55:17]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-10-14 17:57:10]

Description was changed from

==========
Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method
org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method
org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not
discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent,
String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not
discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side
effect is ignored
  In class
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object,
Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG=623989
==========

to

==========
Fix chrome_java FindBugs errors found when switching to n sdk.

(with some simplification of CrashFileManager.java)

FindBugs reported the following issues:
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashFileManager
  In method
org.chromium.chrome.browser.crash.CrashFileManager.getAllFilesSorted()
  Method invoked at CrashFileManager.java:[line 258]
  Known null at CrashFileManager.java:[line 257]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.browser.share.ShareHelper$3
  In method
org.chromium.chrome.browser.share.ShareHelper$3.doInBackground(Void[])
  Reference type java.io.OutputStream
  Obligation to clean up resource created at ShareHelper.java:[line 398] is not
discharged
  Path continues at ShareHelper.java:[line 399]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.prepareUrlIntent(Intent,
String)
  At ChromeActivityTestCaseBase.java:[line 486]
REC_CATCH_EXCEPTION: Exception is caught when Exception is not thrown
  In class org.chromium.chrome.test.ChromeActivityTestCaseBase
  In method
org.chromium.chrome.test.ChromeActivityTestCaseBase.endPerfTest(String)
  At ChromeActivityTestCaseBase.java:[line 859]
OBL_UNSATISFIED_OBLIGATION_EXCEPTION_EDGE: Method may fail to clean up stream or
resource on checked exception
  In class org.chromium.chrome.test.util.RenderUtils
  In method org.chromium.chrome.test.util.RenderUtils.saveBitmap(Bitmap, File)
  Reference type java.io.OutputStream
  Obligation to clean up resource created at RenderUtils.java:[line 179] is not
discharged
  Path continues at RenderUtils.java:[line 180]
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: Possible null pointer dereference due to
return value of called method
  In class org.chromium.chrome.browser.crash.CrashTestCase
  In method org.chromium.chrome.browser.crash.CrashTestCase.tearDown()
  Method invoked at CrashTestCase.java:[line 41]
  Known null at CrashTestCase.java:[line 41]
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT: Return value of method without side
effect is ignored
  In class
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest
  In method
org.chromium.chrome.browser.customtabs.CustomTabFromChromeExternalNavigationTest.testIntentWithRedirectToApp()
  Called method org.chromium.content.browser.test.util.Criteria.equals(Object,
Callable)
  At CustomTabFromChromeExternalNavigationTest.java:[line 121]

BUG=623989

Committed: https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477
Cr-Commit-Position: refs/heads/master@{#425384}
==========

[commit-bot: I haz the power, 2016-10-14 17:57:11]

Patchset 7 (id:??) landed as
https://crrev.com/90b4cf429c7e73e94f04a43bf573d98f03b80477
Cr-Commit-Position: refs/heads/master@{#425384}

[Ilya Sherman, 2016-10-15 00:02:53]

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
(right):

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:295:
List<File> filesBelowMaxTries = new ArrayList<>(unfilteredFiles.length);
nit: This change seems unrelated to the rest of the CL, and didn't seem to be
mentioned in the CL description.  Or, did I miss the reason for this?

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:305:
File[] listCrashFiles(@Nullable final Pattern pattern) {
What does the "crash" in this method name mean?

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:305:
File[] listCrashFiles(@Nullable final Pattern pattern) {
Please add documentation for this method.  In particular, it's not obvious that
the returned values are sorted.  (And, it's not really clear to me why you
decided to make all calls to this method return files in sorted order -- just to
share more code?)

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:317:
File[] minidumps = crashDir.listFiles(filter);
It's not really correct to name this variable "minidumps" -- there are
non-minidump files present in the crash directory as well.

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/javates...
File
chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
(right):

https://codereview.chromium.org/2416963005/diff/120001/chrome/android/javates...
chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java:41:
return;
Please log an error for this case.

[agrieve, 2016-11-02 19:16:32]

On 2016/10/15 00:02:53, Ilya Sherman wrote:
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
> (right):
> 
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:295:
> List<File> filesBelowMaxTries = new ArrayList<>(unfilteredFiles.length);
> nit: This change seems unrelated to the rest of the CL, and didn't seem to be
> mentioned in the CL description.  Or, did I miss the reason for this?
> 
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:305:
> File[] listCrashFiles(@Nullable final Pattern pattern) {
> What does the "crash" in this method name mean?
> 
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:305:
> File[] listCrashFiles(@Nullable final Pattern pattern) {
> Please add documentation for this method.  In particular, it's not obvious
that
> the returned values are sorted.  (And, it's not really clear to me why you
> decided to make all calls to this method return files in sorted order -- just
to
> share more code?)
> 
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/java/sr...
>
chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java:317:
> File[] minidumps = crashDir.listFiles(filter);
> It's not really correct to name this variable "minidumps" -- there are
> non-minidump files present in the crash directory as well.
> 
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/javates...
> File
>
chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
> (right):
> 
>
https://codereview.chromium.org/2416963005/diff/120001/chrome/android/javates...
>
chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java:41:
> return;
> Please log an error for this case.

comments addressed in follow-up: https://codereview.chromium.org/2469403002#