Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2169)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java

Issue 2416963005: Fix chrome_java FindBugs errors found when switching to n sdk. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java
index 9d1ebb223dd1e10f7d1412754990c76e05c565ff..85438516e313581640aba653cd1adc18f68dafb5 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/RenderUtils.java
@@ -177,8 +177,11 @@ public class RenderUtils {
*/
private static void saveBitmap(Bitmap bitmap, File file) throws IOException {
FileOutputStream out = new FileOutputStream(file);
- bitmap.compress(Bitmap.CompressFormat.PNG, 100, out);
- out.close();
+ try {
+ bitmap.compress(Bitmap.CompressFormat.PNG, 100, out);
+ } finally {
+ out.close();
+ }
}
/**
@@ -207,4 +210,4 @@ public class RenderUtils {
if (golden == null) return ComparisonResult.GOLDEN_NOT_FOUND;
return bitmap.sameAs(golden) ? ComparisonResult.MATCH : ComparisonResult.MISMATCH;
}
-}
+}

Powered by Google App Engine
This is Rietveld 408576698