chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java - Issue 2416963005: Fix chrome_java FindBugs errors found when switching to n sdk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java

Issue 2416963005: Fix chrome_java FindBugs errors found when switching to n sdk. (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestCaseBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java

index ef4406d3b1c0b4d67d507c32a92b4c2b8ddbc0f1..b5eb149bdd1f590ac6e1605d7f276d328d430deb 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabFromChromeExternalNavigationTest.java

@@ -118,13 +118,14 @@ public class CustomTabFromChromeExternalNavigationTest extends CustomTabActivity

}

});

- Criteria.equals(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,

+ CriteriaHelper.pollUiThread(Criteria.equals(

+ OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,

new Callable<OverrideUrlLoadingResult>() {

@Override

public OverrideUrlLoadingResult call() throws Exception {

return navigationDelegate.get().getLastOverrideUrlLoadingResultForTests();

}

- });

+ }));

CriteriaHelper.pollUiThread(new Criteria() {

@Override