Issue 2469403002: Post-commit review comments for CrashFileManager

Issue 2469403002: Post-commit review comments for CrashFileManager (Closed)

Created:
4 years, 1 month ago by agrieve

Modified:
4 years, 1 month ago

Reviewers:
Ted C, Ilya Sherman

CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Post-commit review comments for CrashFileManager on change: https://codereview.chromium.org/2416963005/ BUG=623989 Committed: https://crrev.com/f5b99f9e7b86380a23a1ea74db1f9dd74b9341e1 Cr-Commit-Position: refs/heads/master@{#429573}

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java	View		3 chunks	+8 lines, -5 lines	0 comments	Download

Total messages: 13 (7 generated)

agrieve

Sorry this took so long. Had some vacation in the middle, but did not forget!

4 years, 1 month ago (2016-11-02 19:15:57 UTC) #2

Ted C

On 2016/11/02 20:26:27, Ilya Sherman wrote: > LGTM, thanks. rs lgtm

4 years, 1 month ago (2016-11-02 20:30:30 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2469403002/1

4 years, 1 month ago (2016-11-03 14:15:12 UTC) #10

commit-bot: I haz the power

4 years, 1 month ago (2016-11-03 14:21:15 UTC) #13

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f5b99f9e7b86380a23a1ea74db1f9dd74b9341e1
Cr-Commit-Position: refs/heads/master@{#429573}