Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java

Issue 2416963005: Fix chrome_java FindBugs errors found when switching to n sdk. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
index c8ca9ce615e203368d5891d9196ba47f3f443075..92cf250331a2e2c111ba2f5270215f4cfdb983be 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashTestCase.java
@@ -11,8 +11,6 @@ import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
import java.io.PrintWriter;
-import java.util.Arrays;
-import java.util.List;
/**
* Base case for Crash upload related tests.
@@ -38,7 +36,11 @@ public class CrashTestCase extends InstrumentationTestCase {
@Override
protected void tearDown() throws Exception {
super.tearDown();
- List<File> crashFiles = Arrays.asList(mCrashDir.listFiles());
+ File[] crashFiles = mCrashDir.listFiles();
+ if (crashFiles == null) {
+ return;
Ilya Sherman 2016/10/15 00:02:53 Please log an error for this case.
+ }
+
for (File crashFile : crashFiles) {
if (!crashFile.delete()) {
Log.e(TAG, "Unable to delete: " + crashFile.getAbsolutePath());

Powered by Google App Engine
This is Rietveld 408576698