chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java - Issue 2416963005: Fix chrome_java FindBugs errors found when switching to n sdk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

Issue 2416963005: Fix chrome_java FindBugs errors found when switching to n sdk. (Closed)

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

index 9ac82c44c74f70f458be1dbdcb61199bd334c0a8..f8eec1f11e723e9376218e6ed53405a7b13bc802 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java

@@ -152,7 +152,7 @@ public class MinidumpUploadService extends IntentService {

private void handleFindAndUploadLastCrash(Intent intent) {

CrashFileManager fileManager = new CrashFileManager(getApplicationContext().getCacheDir());

- File[] minidumpFiles = fileManager.getAllMinidumpFilesSorted(MAX_TRIES_ALLOWED);

+ File[] minidumpFiles = fileManager.getAllMinidumpFiles(MAX_TRIES_ALLOWED);

if (minidumpFiles.length == 0) {

// Try again later. Maybe the minidump hasn't finished being written.

Log.d(TAG, "Could not find any crash dumps to upload");