Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui

Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui

BUG=581865
R=dpapad@chromium.org
TBR=dbeam@chromium.org

Committed: https://crrev.com/847899cb8eb36ef4c6cc02f276c0c7d4cca86e55
Cr-Commit-Position: refs/heads/master@{#425136}

[dcheng, 2016-10-13 17:38:53]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:39:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-10-13 17:40:26]

dcheng@chromium.org changed reviewers:
+ dpapad@chromium.org

[dcheng, 2016-10-13 17:40:46]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 17:41:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 18:14:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 18:14:44]

Dry run: This issue passed the CQ dry run.

[dpapad, 2016-10-13 18:36:02]

LGTM

https://codereview.chromium.org/2415993002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/2415993002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:186:
base::DictionaryValue* result = new base::DictionaryValue();
How about this one?

[dcheng, 2016-10-13 19:41:07]

https://codereview.chromium.org/2415993002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
(right):

https://codereview.chromium.org/2415993002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc:186:
base::DictionaryValue* result = new base::DictionaryValue();
On 2016/10/13 18:36:02, dpapad wrote:
> How about this one?

Mostly it's about unblocking the removal of ListValue::Append. Presumably, this
is getting used in another context (probably DictionaryValue::Set?) and I'll
address this once we're done with Append().

[dcheng, 2016-10-13 19:41:13]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:41:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 19:50:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:50:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2016-10-13 19:55:54]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/webui

BUG=581865
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/webui

BUG=581865
R=dpapad@chromium.org
TBR=dbeam@chromium.org
==========

[dcheng, 2016-10-13 19:55:54]

dcheng@chromium.org changed reviewers:
+ dbeam@chromium.org

[dcheng, 2016-10-13 19:56:08]

TBRing dbeam for options, which is apparently noparent

[dcheng, 2016-10-13 19:56:18]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-10-13 19:56:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 20:04:29]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/webui

BUG=581865
R=dpapad@chromium.org
TBR=dbeam@chromium.org
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/webui

BUG=581865
R=dpapad@chromium.org
TBR=dbeam@chromium.org
==========

[commit-bot: I haz the power, 2016-10-13 20:04:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-13 20:07:34]

Description was changed from

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/webui

BUG=581865
R=dpapad@chromium.org
TBR=dbeam@chromium.org
==========

to

==========
Remove use of deprecated base::ListValue::Append(Value*) overload in
//chrome/browser/ui/webui

BUG=581865
R=dpapad@chromium.org
TBR=dbeam@chromium.org

Committed: https://crrev.com/847899cb8eb36ef4c6cc02f276c0c7d4cca86e55
Cr-Commit-Position: refs/heads/master@{#425136}
==========

[commit-bot: I haz the power, 2016-10-13 20:07:36]

Patchset 2 (id:??) landed as
https://crrev.com/847899cb8eb36ef4c6cc02f276c0c7d4cca86e55
Cr-Commit-Position: refs/heads/master@{#425136}