Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Unified Diff: chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

Issue 2415993002: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui (Closed)
Patch Set: Add missing includes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc b/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
index 23ec4ec3ae01c6e9594c34fb9de15bb29cd71dc3..276cca0d767b902be2943cf36c67df1d2c8db6d0 100644
--- a/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
@@ -70,7 +70,7 @@ void GetGCacheContents(const base::FilePath& root_path,
DCHECK(gcache_summary);
// Use this map to sort the result list by the path.
- std::map<base::FilePath, base::DictionaryValue*> files;
+ std::map<base::FilePath, std::unique_ptr<base::DictionaryValue>> files;
const int options = (base::FileEnumerator::FILES |
base::FileEnumerator::DIRECTORIES |
@@ -86,7 +86,7 @@ void GetGCacheContents(const base::FilePath& root_path,
const bool is_symbolic_link = base::IsLink(info.GetName());
const base::Time last_modified = info.GetLastModifiedTime();
- base::DictionaryValue* entry = new base::DictionaryValue;
+ auto entry = base::MakeUnique<base::DictionaryValue>();
entry->SetString("path", current.value());
// Use double instead of integer for large files.
entry->SetDouble("size", size);
@@ -99,16 +99,14 @@ void GetGCacheContents(const base::FilePath& root_path,
entry->SetString(
"permission",
base::StringPrintf("%03o", info.stat().st_mode & 0x1ff));
- files[current] = entry;
+ files[current] = std::move(entry);
total_size += size;
}
// Convert |files| into |gcache_contents|.
- for (std::map<base::FilePath, base::DictionaryValue*>::const_iterator
- iter = files.begin(); iter != files.end(); ++iter) {
- gcache_contents->Append(iter->second);
- }
+ for (auto& it : files)
+ gcache_contents->Append(std::move(it.second));
gcache_summary->SetDouble("total_size", total_size);
}

Powered by Google App Engine
This is Rietveld 408576698