Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui

chrome/browser/ui/webui/options/chromeos/display_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/chromeos/display_options_handler.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 140 matching lines @@
     return mode;
   }
 
   // Used to select the actual mode.
   mode = new display::ManagedDisplayMode(
       size, refresh_rate, false /* interlaced */, false /* native */, ui_scale,
       device_scale_factor);
   return mode;
 }
 
-base::DictionaryValue* ConvertDisplayModeToValue(
+std::unique_ptr<base::DictionaryValue> ConvertDisplayModeToValue(
     int64_t display_id,
     const scoped_refptr<display::ManagedDisplayMode>& mode) {
   bool is_internal = display::Display::HasInternalDisplay() &&
                      display::Display::InternalDisplayId() == display_id;
-  base::DictionaryValue* result = new base::DictionaryValue();
+  auto result = base::MakeUnique<base::DictionaryValue>();
   gfx::Size size_dip = mode->GetSizeInDIP(is_internal);
   result->SetInteger("width", size_dip.width());
   result->SetInteger("height", size_dip.height());
   result->SetInteger("originalWidth", mode->size().width());
   result->SetInteger("originalHeight", mode->size().height());
   result->SetDouble("deviceScaleFactor", mode->device_scale_factor());
   result->SetDouble("scale", mode->ui_scale());
   result->SetDouble("refreshRate", mode->refresh_rate());
   result->SetBoolean("isBest",
                      is_internal ? (mode->ui_scale() == 1.0f) : mode->native());
   result->SetBoolean("isNative", mode->native());
   result->SetBoolean(
       "selected",
       mode->IsEquivalent(
           GetDisplayManager()->GetActiveModeForDisplayId(display_id)));
   return result;
 }
 
 base::DictionaryValue* ConvertBoundsToValue(const gfx::Rect& bounds) {
   base::DictionaryValue* result = new base::DictionaryValue();

[dpapad, 2016/10/13 18:36:02]

How about this one?

[dcheng, 2016/10/13 19:41:07]

Mostly it's about unblocking the removal of ListValue::Append. Presumably, this
is getting used in another context (probably DictionaryValue::Set?) and I'll
address this once we're done with Append().

   result->SetInteger("left", bounds.x());
   result->SetInteger("top", bounds.y());
   result->SetInteger("width", bounds.width());
   result->SetInteger("height", bounds.height());
   return result;
 }
 
 }  // namespace
 
 DisplayOptionsHandler::DisplayOptionsHandler() {
@@ skipping 381 matching lines @@
   bool enable = false;
   if (!args->GetBoolean(0, &enable))
     NOTREACHED();
 
   GetDisplayManager()->SetDefaultMultiDisplayModeForCurrentDisplays(
       enable ? ash::DisplayManager::UNIFIED : ash::DisplayManager::EXTENDED);
 }
 
 }  // namespace options
 }  // namespace chromeos