chrome/browser/ui/webui/chromeos/network_ui.cc - Issue 2415993002: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/network_ui.cc

Issue 2415993002: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui (Closed)

Patch Set: Add missing includes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/chromeos/network_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/network_ui.cc b/chrome/browser/ui/webui/chromeos/network_ui.cc

index 8c105fd89e6ed791c59d3a7c37d73c32b882cf5b..8dfc7c2b4edf69bff47da32131a69f4f470a542a 100644

--- a/chrome/browser/ui/webui/chromeos/network_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/network_ui.cc

@@ -60,7 +60,7 @@ void SetDeviceProperties(base::DictionaryValue* dictionary) {

std::unique_ptr<base::ListValue> ip_configs(new base::ListValue);

for (base::DictionaryValue::Iterator iter(device_state->ip_configs());

!iter.IsAtEnd(); iter.Advance()) {

- ip_configs->Append(iter.value().DeepCopy());

+ ip_configs->Append(iter.value().CreateDeepCopy());

}

device_dictionary->SetWithoutPathExpansion(shill::kIPConfigsProperty,

ip_configs.release());