Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3345)

Unified Diff: chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc

Issue 2415993002: Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui (Closed)
Patch Set: Add missing includes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
index 98ee60c16dcafe8cc6eba5539fcfb381de99a150..af896ab8a3a0a68718cef29cf23db97ce1948719 100644
--- a/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
+++ b/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc
@@ -6,6 +6,7 @@
#include <utility>
+#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
@@ -232,13 +233,13 @@ void SupervisedUserCreationScreenHandler::Show() {
it != users.end();
++it) {
bool is_owner = ((*it)->email() == owner);
- base::DictionaryValue* user_dict = new base::DictionaryValue();
+ auto user_dict = base::MakeUnique<base::DictionaryValue>();
UserSelectionScreen::FillUserDictionary(
*it, is_owner, false, /* is_signin_to_add */
proximity_auth::ScreenlockBridge::LockHandler::OFFLINE_PASSWORD,
NULL, /* public_session_recommended_locales */
- user_dict);
- users_list->Append(user_dict);
+ user_dict.get());
+ users_list->Append(std::move(user_dict));
}
data->Set("managers", users_list.release());
ShowScreenWithData(OobeScreen::SCREEN_CREATE_SUPERVISED_USER_FLOW,

Powered by Google App Engine
This is Rietveld 408576698