Remove use of deprecated base::ListValue::Append(Value*) overload in //chrome/browser/ui/webui

chrome/browser/ui/webui/chromeos/drive_internals_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/chromeos/drive_internals_ui.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <memory>
@@ skipping 52 matching lines @@
 //
 // The list is sorted by the path.
 void GetGCacheContents(const base::FilePath& root_path,
                        base::ListValue* gcache_contents,
                        base::DictionaryValue* gcache_summary) {
   DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(gcache_contents);
   DCHECK(gcache_summary);
 
   // Use this map to sort the result list by the path.
-  std::map<base::FilePath, base::DictionaryValue*> files;
+  std::map<base::FilePath, std::unique_ptr<base::DictionaryValue>> files;
 
   const int options = (base::FileEnumerator::FILES |
                        base::FileEnumerator::DIRECTORIES |
                        base::FileEnumerator::SHOW_SYM_LINKS);
   base::FileEnumerator enumerator(root_path, true /* recursive */, options);
 
   int64_t total_size = 0;
   for (base::FilePath current = enumerator.Next(); !current.empty();
        current = enumerator.Next()) {
     base::FileEnumerator::FileInfo info = enumerator.GetInfo();
     int64_t size = info.GetSize();
     const bool is_directory = info.IsDirectory();
     const bool is_symbolic_link = base::IsLink(info.GetName());
     const base::Time last_modified = info.GetLastModifiedTime();
 
-    base::DictionaryValue* entry = new base::DictionaryValue;
+    auto entry = base::MakeUnique<base::DictionaryValue>();
     entry->SetString("path", current.value());
     // Use double instead of integer for large files.
     entry->SetDouble("size", size);
     entry->SetBoolean("is_directory", is_directory);
     entry->SetBoolean("is_symbolic_link", is_symbolic_link);
     entry->SetString(
         "last_modified",
         google_apis::util::FormatTimeAsStringLocaltime(last_modified));
     // Print lower 9 bits in octal format.
     entry->SetString(
         "permission",
         base::StringPrintf("%03o", info.stat().st_mode & 0x1ff));
-    files[current] = entry;
+    files[current] = std::move(entry);
 
     total_size += size;
   }
 
   // Convert |files| into |gcache_contents|.
-  for (std::map<base::FilePath, base::DictionaryValue*>::const_iterator
-           iter = files.begin(); iter != files.end(); ++iter) {
-    gcache_contents->Append(iter->second);
-  }
+  for (auto& it : files)
+    gcache_contents->Append(std::move(it.second));
 
   gcache_summary->SetDouble("total_size", total_size);
 }
 
 // Gets the available disk space for the path |home_path|.
 void GetFreeDiskSpace(const base::FilePath& home_path,
                       base::DictionaryValue* local_storage_summary) {
   DCHECK(!BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK(local_storage_summary);
 
@@ skipping 779 matching lines @@
       content::WebUIDataSource::Create(chrome::kChromeUIDriveInternalsHost);
   source->AddResourcePath("drive_internals.css", IDR_DRIVE_INTERNALS_CSS);
   source->AddResourcePath("drive_internals.js", IDR_DRIVE_INTERNALS_JS);
   source->SetDefaultResource(IDR_DRIVE_INTERNALS_HTML);
 
   Profile* profile = Profile::FromWebUI(web_ui);
   content::WebUIDataSource::Add(profile, source);
 }
 
 }  // namespace chromeos