Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 2414263002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, dcheng, groby+blinkspell_chromium.org, kinuko+watch, mlamouri+watch-blink_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange BUG=590369 Committed: https://crrev.com/fa41120b705ec7ae5fc8c8f280bd76a05bfc97ef Cr-Commit-Position: refs/heads/master@{#425279}

Patch Set 1 #

Patch Set 2 : minor revision #

Patch Set 3 : Patched in copy/paste #

Total comments: 2

Patch Set 4 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -11 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 2 4 chunks +27 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSurroundingText.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-14 08:06:59 UTC) #12
yosin_UTC9
lgtm w/ small nit https://codereview.chromium.org/2414263002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right): https://codereview.chromium.org/2414263002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp#newcode998 third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:998: const EphemeralRange range = selection.toNormalizedEphemeralRange(); ...
4 years, 2 months ago (2016-10-14 08:13:00 UTC) #13
tkent
lgtm
4 years, 2 months ago (2016-10-14 08:24:23 UTC) #14
Xiaocheng
Thanks! Committing with nit fixed. https://codereview.chromium.org/2414263002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right): https://codereview.chromium.org/2414263002/diff/40001/third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp#newcode998 third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:998: const EphemeralRange range = ...
4 years, 2 months ago (2016-10-14 08:35:14 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2414263002/60001
4 years, 2 months ago (2016-10-14 08:35:17 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-14 09:34:40 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 09:36:12 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fa41120b705ec7ae5fc8c8f280bd76a05bfc97ef
Cr-Commit-Position: refs/heads/master@{#425279}

Powered by Google App Engine
This is Rietveld 408576698