Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange

third_party/WebKit/Source/core/editing/DOMSelection.cpp

 /*
  * Copyright (C) 2007, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 507 matching lines @@
 
 void DOMSelection::deleteFromDocument() {
   if (!isAvailable())
     return;
 
   FrameSelection& selection = frame()->selection();
 
   if (selection.isNone())
     return;
 
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // |VisibleSelection::toNormalizedEphemeralRange| requires clean layout.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   Range* selectedRange =
       createRange(selection.selection().toNormalizedEphemeralRange());
   if (!selectedRange)
     return;
 
   selectedRange->deleteContents(ASSERT_NO_EXCEPTION);
 
   setBaseAndExtent(selectedRange->startContainer(),
                    selectedRange->startOffset(),
                    selectedRange->startContainer(),
                    selectedRange->startOffset(), ASSERT_NO_EXCEPTION);
 }
 
 bool DOMSelection::containsNode(const Node* n, bool allowPartial) const {
   DCHECK(n);
 
   if (!isAvailable())
     return false;
 
   FrameSelection& selection = frame()->selection();
 
   if (frame()->document() != n->document() || selection.isNone())
     return false;
 
   unsigned nodeIndex = n->nodeIndex();
+
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // |VisibleSelection::toNormalizedEphemeralRange| requires clean layout.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   const EphemeralRange selectedRange =
       selection.selection().toNormalizedEphemeralRange();
 
   ContainerNode* parentNode = n->parentNode();
   if (!parentNode)
     return false;
 
   const Position startPosition =
       selectedRange.startPosition().toOffsetInAnchor();
   const Position endPosition = selectedRange.endPosition().toOffsetInAnchor();
@@ skipping 96 matching lines @@
     m_treeScope->document().addConsoleMessage(
         ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 DEFINE_TRACE(DOMSelection) {
   visitor->trace(m_treeScope);
   DOMWindowProperty::trace(visitor);
 }
 
 }  // namespace blink