Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 429 matching lines @@
       fragment = createFragmentFromMarkupWithContext(
           *frame().document(), markup, fragmentStart, fragmentEnd, url,
           DisallowScriptingAndPluginContent);
     }
   }
 
   if (!fragment) {
     String text = pasteboard->plainText();
     if (!text.isEmpty()) {
       chosePlainText = true;
+
+      // TODO(xiaochengh): Use of updateStyleAndLayoutIgnorePendingStylesheets
+      // needs to be audited.  See http://crbug.com/590369 for more details.
+      // |selectedRange| requires clean layout for visible selection
+      // normalization.
+      frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
       fragment = createFragmentFromText(selectedRange(), text);
     }
   }
 
   if (fragment)
     pasteAsFragment(fragment, canSmartReplaceWithPasteboard(pasteboard),
                     chosePlainText);
 }
 
 void Editor::writeSelectionToPasteboard() {
@@ skipping 535 matching lines @@
                   : ScrollAlignment::alignCenterIfNeeded);
 
   return true;
 }
 
 void Editor::cut(EditorCommandSource source) {
   if (tryDHTMLCut())
     return;  // DHTML did the whole operation
   if (!canCut())
     return;
+
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // |tryDHTMLCut| dispatches cut event, which may make layout dirty, but we
+  // need clean layout to obtain the selected content.
+  frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   // TODO(yosin) We should use early return style here.
   if (canDeleteRange(selectedRange())) {
     spellChecker().updateMarkersForWordsAffectedByEditing(true);
     if (enclosingTextFormControl(frame().selection().start())) {
       String plainText = frame().selectedTextForClipboard();
       Pasteboard::generalPasteboard()->writePlainText(
           plainText, canSmartCopyOrDelete() ? Pasteboard::CanSmartReplace
                                             : Pasteboard::CannotSmartReplace);
     } else {
       writeSelectionToPasteboard();
@@ skipping 13 matching lines @@
         canSmartCopyOrDelete() ? DeleteMode::Smart : DeleteMode::Simple,
         InputEvent::InputType::DeleteByCut);
   }
 }
 
 void Editor::copy() {
   if (tryDHTMLCopy())
     return;  // DHTML did the whole operation
   if (!canCopy())
     return;
+
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // |tryDHTMLCopy| dispatches copy event, which may make layout dirty, but
+  // we need clean layout to obtain the selected content.
+  frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   if (enclosingTextFormControl(frame().selection().start())) {
     Pasteboard::generalPasteboard()->writePlainText(
         frame().selectedTextForClipboard(),
         canSmartCopyOrDelete() ? Pasteboard::CanSmartReplace
                                : Pasteboard::CannotSmartReplace);
   } else {
     Document* document = frame().document();
     if (HTMLImageElement* imageElement =
             imageElementFromImageDocument(document))
       writeImageNodeToPasteboard(Pasteboard::generalPasteboard(), imageElement,
@@ skipping 43 matching lines @@
     return;
   if (!canPaste())
     return;
   spellChecker().updateMarkersForWordsAffectedByEditing(false);
   pasteAsPlainTextWithPasteboard(Pasteboard::generalPasteboard());
 }
 
 void Editor::performDelete() {
   if (!canDelete())
     return;
+
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // |selectedRange| requires clean layout for visible selection normalization.
+  frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   addToKillRing(selectedRange());
   // TODO(chongz): |Editor::performDelete()| has no direction.
   // https://github.com/w3c/editing/issues/130
   deleteSelectionWithSmartDelete(
       canSmartCopyOrDelete() ? DeleteMode::Smart : DeleteMode::Simple,
       InputEvent::InputType::DeleteContentBackward);
 
   // clear the "start new kill ring sequence" setting, because it was set to
   // true when the selection was updated by deleting the range
   setStartNewKillRingSequence(false);
@@ skipping 508 matching lines @@
 }
 
 DEFINE_TRACE(Editor) {
   visitor->trace(m_frame);
   visitor->trace(m_lastEditCommand);
   visitor->trace(m_undoStack);
   visitor->trace(m_mark);
 }
 
 }  // namespace blink