Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange

third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 1093 matching lines @@
   frame()->spellChecker().requestTextChecking(
       *webElement.constUnwrap<Element>());
 }
 
 void WebLocalFrameImpl::replaceMisspelledRange(const WebString& text) {
   // If this caret selection has two or more markers, this function replace the
   // range covered by the first marker with the specified word as Microsoft Word
   // does.
   if (pluginContainerFromFrame(frame()))
     return;
+
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  see http://crbug.com/590369 for more details.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   frame()->spellChecker().replaceMisspelledRange(text);
 }
 
 void WebLocalFrameImpl::removeSpellingMarkers() {
   frame()->spellChecker().removeSpellingMarkers();
 }
 
 bool WebLocalFrameImpl::hasSelection() const {
   WebPluginContainerImpl* pluginContainer = pluginContainerFromFrame(frame());
   if (pluginContainer)
     return pluginContainer->plugin()->hasSelection();
 
   // frame()->selection()->isNone() never returns true.
   return frame()->selection().start() != frame()->selection().end();
 }
 
 WebRange WebLocalFrameImpl::selectionRange() const {
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   return frame()->selection().selection().toNormalizedEphemeralRange();
 }
 
 WebString WebLocalFrameImpl::selectionAsText() const {
   WebPluginContainerImpl* pluginContainer = pluginContainerFromFrame(frame());
   if (pluginContainer)
     return pluginContainer->plugin()->selectionAsText();
 
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
   String text = frame()->selection().selectedText(
       TextIteratorEmitsObjectReplacementCharacter);
 #if OS(WIN)
   replaceNewlinesWithWindowsStyleNewlines(text);
 #endif
   replaceNBSPWithSpace(text);
   return text;
 }
 
 WebString WebLocalFrameImpl::selectionAsMarkup() const {
   WebPluginContainerImpl* pluginContainer = pluginContainerFromFrame(frame());
   if (pluginContainer)
     return pluginContainer->plugin()->selectionAsMarkup();
 
+  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+  // needs to be audited.  See http://crbug.com/590369 for more details.
+  // Selection normalization and markup generation require clean layout.
+  frame()->document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
   return frame()->selection().selectedHTMLForClipboard();
 }
 
 void WebLocalFrameImpl::selectWordAroundPosition(LocalFrame* frame,
                                                  VisiblePosition position) {
   TRACE_EVENT0("blink", "WebLocalFrameImpl::selectWordAroundPosition");
 
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  see http://crbug.com/590369 for more details.
   frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();
@@ skipping 1191 matching lines @@
     feature = UseCounter::ChromeLoadTimesNpnNegotiatedProtocol;
   } else if (metric == "wasAlternateProtocolAvailable") {
     feature = UseCounter::ChromeLoadTimesWasAlternateProtocolAvailable;
   } else if (metric == "connectionInfo") {
     feature = UseCounter::ChromeLoadTimesConnectionInfo;
   }
   UseCounter::count(frame(), feature);
 }
 
 }  // namespace blink