Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange

third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 955 matching lines @@
   return false;
 }
 
 bool SpellChecker::selectionStartHasSpellingMarkerFor(int from,
                                                       int length) const {
   return selectionStartHasMarkerFor(DocumentMarker::Spelling, from, length);
 }
 
 void SpellChecker::removeMarkers(const VisibleSelection& selection,
                                  DocumentMarker::MarkerTypes markerTypes) {
-  const EphemeralRange range = selection.toNormalizedEphemeralRange();
-  if (range.isNull())
-    return;
-
   // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
   // needs to be audited.  See http://crbug.com/590369 for more details.
   frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
+  const EphemeralRange& range = selection.toNormalizedEphemeralRange();
+  if (range.isNull())
+    return;
+
   frame().document()->markers().removeMarkers(range, markerTypes);
 }
 
 void SpellChecker::cancelCheck() {
   m_spellCheckRequester->cancelCheck();
 }
 
 void SpellChecker::requestTextChecking(const Element& element) {
   if (!element.isSpellCheckingEnabled())
     return;
@@ skipping 125 matching lines @@
         startOfNextParagraph(createVisiblePosition(paragraphEnd));
     paragraphStart = newParagraphStart.toParentAnchoredPosition();
     paragraphEnd = endOfParagraph(newParagraphStart).toParentAnchoredPosition();
     firstIteration = false;
     totalLengthProcessed += currentLength;
   }
   return std::make_pair(firstFoundItem, firstFoundOffset);
 }
 
 }  // namespace blink