third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp - Issue 2414263002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2414263002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in toNormalizedEphemeralRange (Closed)

Patch Set: fix nit Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

index 8f8ca8444e13102b3b8c81a8f059096fd023147c..33992d4370d1705c87db5ca583a5da70e726af9f 100644

--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

@@ -794,6 +794,10 @@ bool WebFrameWidgetImpl::selectionTextDirection(WebTextDirection& start,

if (!frame)

return false;

+ // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

+ // needs to be audited. See http://crbug.com/590369 for more details.

+ frame->document()->updateStyleAndLayoutIgnorePendingStylesheets();

FrameSelection& selection = frame->selection();

if (selection.selection().toNormalizedEphemeralRange().isNull())

return false;