Simplify the JavaScriptDialogManager.

Simplify the JavaScriptDialogManager.

- This collapses two closely-related calls into just one.
- This allows the WebContents to specify no callbacks, which avoids calling back to it while it's being destructed. (This is a state that is not possible now, but will be possible soon.)

BUG=629964
TEST=existing tests

Committed: https://crrev.com/5d3b869bc09c586f076e3d78d8b8966b75dcf6c9
Cr-Commit-Position: refs/heads/master@{#424875}

[Avi (use Gerrit), 2016-10-12 01:33:56]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 01:34:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-10-12 01:36:33]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 01:36:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 02:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 02:22:57]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-10-12 03:04:14]

avi@chromium.org changed reviewers:
+ nasko@chromium.org

[Avi (use Gerrit), 2016-10-12 17:41:37]

avi@chromium.org changed reviewers:
+ jam@chromium.org
- nasko@chromium.org

[Avi (use Gerrit), 2016-10-12 17:41:38]

John, can you sanity-check this interface change?

[jam, 2016-10-12 21:27:25]

lgtm

[Avi (use Gerrit), 2016-10-12 21:53:47]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-10-12 21:54:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 22:01:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-12 22:03:32]

Description was changed from

==========
Simplify the JavaScriptDialogManager.

- This collapses two closely-related calls into just one.
- This allows the WebContents to specify no callbacks, which avoids calling back
to it while it's being destructed. (This is a state that is not possible now,
but will be possible soon.)

BUG=629964
TEST=existing tests
==========

to

==========
Simplify the JavaScriptDialogManager.

- This collapses two closely-related calls into just one.
- This allows the WebContents to specify no callbacks, which avoids calling back
to it while it's being destructed. (This is a state that is not possible now,
but will be possible soon.)

BUG=629964
TEST=existing tests

Committed: https://crrev.com/5d3b869bc09c586f076e3d78d8b8966b75dcf6c9
Cr-Commit-Position: refs/heads/master@{#424875}
==========

[commit-bot: I haz the power, 2016-10-12 22:03:34]

Patchset 2 (id:??) landed as
https://crrev.com/5d3b869bc09c586f076e3d78d8b8966b75dcf6c9
Cr-Commit-Position: refs/heads/master@{#424875}