components/app_modal/javascript_app_modal_dialog.h - Issue 2412843002: Simplify the JavaScriptDialogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/javascript_app_modal_dialog.h

Issue 2412843002: Simplify the JavaScriptDialogManager. (Closed)

Patch Set: braces Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/app_modal/javascript_app_modal_dialog.h

diff --git a/components/app_modal/javascript_app_modal_dialog.h b/components/app_modal/javascript_app_modal_dialog.h

index 0fb4d899788fb1f1e598e72378ef3d54e1a8aaec..4bcab18393ff8670b27e7eca5b35faf225762f89 100644

--- a/components/app_modal/javascript_app_modal_dialog.h

+++ b/components/app_modal/javascript_app_modal_dialog.h

@@ -52,7 +52,7 @@ class JavaScriptAppModalDialog : public AppModalDialog {

// Overridden from AppModalDialog:

NativeAppModalDialog* CreateNativeDialog() override;

bool IsJavaScriptModalDialog() override;

- void Invalidate() override;

+ void Invalidate(bool suppress_callbacks) override;

// Callbacks from NativeDialog when the user accepts or cancels the dialog.

void OnCancel(bool suppress_js_messages);