chrome/browser/extensions/content_script_apitest.cc - Issue 2412843002: Simplify the JavaScriptDialogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/content_script_apitest.cc

Issue 2412843002: Simplify the JavaScriptDialogManager. (Closed)

Patch Set: braces Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/content_script_apitest.cc

diff --git a/chrome/browser/extensions/content_script_apitest.cc b/chrome/browser/extensions/content_script_apitest.cc

index b1c8120a03a3722da8bc5cdbd3fd136a17931bd0..37d131735f5f2eedeb285f4c895864f259e8fab8 100644

--- a/chrome/browser/extensions/content_script_apitest.cc

+++ b/chrome/browser/extensions/content_script_apitest.cc

@@ -176,7 +176,7 @@ DialogHelper::~DialogHelper() {

}

void DialogHelper::CloseDialogs() {

- dialog_manager_->CancelActiveAndPendingDialogs(web_contents_);

+ dialog_manager_->CancelDialogs(web_contents_, false, false);

}

void DialogHelper::DialogOpened() {