Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc

Issue 2412843002: Simplify the JavaScriptDialogManager. (Closed)
Patch Set: braces Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/guest_view/web_view/javascript_dialog_helper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
diff --git a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
index bc55c9eed0823d8125d4772d2119aa04fd9e9fad..9a9763d347f2b3a2c1b96b9fcb3daecd14882d57 100644
--- a/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
+++ b/extensions/browser/guest_view/web_view/javascript_dialog_helper.cc
@@ -85,13 +85,9 @@ bool JavaScriptDialogHelper::HandleJavaScriptDialog(
return false;
}
-void JavaScriptDialogHelper::CancelActiveAndPendingDialogs(
- content::WebContents* web_contents) {
-}
-
-void JavaScriptDialogHelper::ResetDialogState(
- content::WebContents* web_contents) {
-}
+void JavaScriptDialogHelper::CancelDialogs(content::WebContents* web_contents,
+ bool suppress_callbacks,
+ bool reset_state) {}
void JavaScriptDialogHelper::OnPermissionResponse(
const DialogClosedCallback& callback,
« no previous file with comments | « extensions/browser/guest_view/web_view/javascript_dialog_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698