components/app_modal/app_modal_dialog.cc - Issue 2412843002: Simplify the JavaScriptDialogManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/app_modal_dialog.cc

Issue 2412843002: Simplify the JavaScriptDialogManager. (Closed)

Patch Set: braces Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/app_modal/app_modal_dialog.cc

diff --git a/components/app_modal/app_modal_dialog.cc b/components/app_modal/app_modal_dialog.cc

index 8689b7fc03a199bdde4a33b8cb146113ec0c88a1..4e9ac92c751bc0fe172fd7027a3678888730e485 100644

--- a/components/app_modal/app_modal_dialog.cc

+++ b/components/app_modal/app_modal_dialog.cc

@@ -52,7 +52,7 @@ bool AppModalDialog::IsValid() {

return valid_;

}

-void AppModalDialog::Invalidate() {

+void AppModalDialog::Invalidate(bool suppress_callbacks) {

valid_ = false;

}