Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1284)

Unified Diff: content/browser/web_contents/web_contents_impl_unittest.cc

Issue 2412843002: Simplify the JavaScriptDialogManager. (Closed)
Patch Set: braces Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl_unittest.cc
diff --git a/content/browser/web_contents/web_contents_impl_unittest.cc b/content/browser/web_contents/web_contents_impl_unittest.cc
index f426aa3f6d7a285f4fc451793eea66c583893975..b1373bdb59b6e1c9ebfb7f68932bd4f244449b23 100644
--- a/content/browser/web_contents/web_contents_impl_unittest.cc
+++ b/content/browser/web_contents/web_contents_impl_unittest.cc
@@ -3425,9 +3425,12 @@ class TestJavaScriptDialogManager : public JavaScriptDialogManager {
return true;
}
- void CancelActiveAndPendingDialogs(WebContents* web_contents) override {}
-
- void ResetDialogState(WebContents* web_contents) override { ++reset_count_; }
+ void CancelDialogs(WebContents* web_contents,
+ bool suppress_callbacks,
+ bool reset_state) override {
+ if (reset_state)
+ ++reset_count_;
+ }
private:
size_t reset_count_ = 0;
« no previous file with comments | « content/browser/web_contents/web_contents_impl_browsertest.cc ('k') | content/public/browser/javascript_dialog_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698