Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() (Closed)

Created:
4 years, 2 months ago by mgersh
Modified:
4 years, 2 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() The timestamp is available even when there is no response, so this name makes more sense. BUG=629194 Committed: https://crrev.com/1ad34d61a5dc3b4415c9448885a36e8f442b2c0b Cr-Commit-Position: refs/heads/master@{#423872}

Patch Set 1 #

Messages

Total messages: 11 (5 generated)
mgersh
PTAL
4 years, 2 months ago (2016-10-07 15:14:10 UTC) #3
xunjieli
On 2016/10/07 15:14:10, mgersh wrote: > PTAL lgtm. Has M55 branched? If so, let's also ...
4 years, 2 months ago (2016-10-07 15:59:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401933002/1
4 years, 2 months ago (2016-10-07 16:01:54 UTC) #6
mgersh
On 2016/10/07 15:59:26, xunjieli wrote: > On 2016/10/07 15:14:10, mgersh wrote: > > PTAL > ...
4 years, 2 months ago (2016-10-07 16:05:38 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 16:11:48 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:13:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ad34d61a5dc3b4415c9448885a36e8f442b2c0b
Cr-Commit-Position: refs/heads/master@{#423872}

Powered by Google App Engine
This is Rietveld 408576698