Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java

Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
diff --git a/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java b/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
index 85dd58478f1324797c1c5166c4d7ac9b4d479a26..8c681727db96eeda9d4131ee18a0c60e5a5d0774 100644
--- a/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
+++ b/components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java
@@ -67,7 +67,7 @@ public final class RequestFinishedInfo {
* <li>{@link #getSendingStart sending start}</li>
* <li>{@link #getSendingEnd sending end}</li>
* <li>{@link #getResponseStart response start}</li>
- * <li>{@link #getResponseEnd response end}</li>
+ * <li>{@link #getRequestEnd request end}</li>
* </ol>
*
* Start times are reported as the time when a request started blocking on event, not when the
@@ -196,12 +196,11 @@ public final class RequestFinishedInfo {
public abstract Date getResponseStart();
/**
- * Returns time when last byte of response was received.
- * @return {@link java.util.Date} representing when the last byte of the response was
- * received.
+ * Returns time when the request finished.
+ * @return {@link java.util.Date} representing when the request finished.
*/
@Nullable
- public abstract Date getResponseEnd();
+ public abstract Date getRequestEnd();
/**
* Returns whether the socket was reused from a previous request. In HTTP/2 or QUIC, if
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698