components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java - Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

index a1c17e7999ee2b3f61a98217375fe156c70b498d..378b09560940484c07bd6168f94214a5908bed8a 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

@@ -1205,11 +1205,10 @@ public class BidirectionalStreamTest extends CronetTestBase {

// metrics.getResponseStart() can be null or non null

// TODO(xunjieli): It's weird to have a null response start but a

// non-null response end.

- assertNotNull(metrics.getResponseEnd());

- MetricsTestUtil.assertAfter(endTime, metrics.getResponseEnd());

+ assertNotNull(metrics.getRequestEnd());

+ MetricsTestUtil.assertAfter(endTime, metrics.getRequestEnd());

// Entire request should take more than 0 ms

- assertTrue(

- metrics.getResponseEnd().getTime() - metrics.getRequestStart().getTime() > 0);

+ assertTrue(metrics.getRequestEnd().getTime() - metrics.getRequestStart().getTime() > 0);

}

assertEquals(expectError, callback.mError != null);

assertEquals(expectError, callback.mOnErrorCalled);