components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java - Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java ('k') | components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

index a58774129a83861db5aef6041958b5187b7e74ff..d9c80a1b4d448ede5284707aeddcfb8b4db67f21 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java

@@ -629,7 +629,7 @@ public class CronetBidirectionalStream extends BidirectionalStream {

private void onMetricsCollected(long requestStartMs, long dnsStartMs, long dnsEndMs,

long connectStartMs, long connectEndMs, long sslStartMs, long sslEndMs,

long sendingStartMs, long sendingEndMs, long pushStartMs, long pushEndMs,

- long responseStartMs, long responseEndMs, boolean socketReused, long sentBytesCount,

+ long responseStartMs, long requestEndMs, boolean socketReused, long sentBytesCount,

long receivedBytesCount) {

synchronized (mNativeStreamLock) {

if (mMetrics != null) {

@@ -637,7 +637,7 @@ public class CronetBidirectionalStream extends BidirectionalStream {

}

mMetrics = new CronetMetrics(requestStartMs, dnsStartMs, dnsEndMs, connectStartMs,

connectEndMs, sslStartMs, sslEndMs, sendingStartMs, sendingEndMs, pushStartMs,

- pushEndMs, responseStartMs, responseEndMs, socketReused, sentBytesCount,

+ pushEndMs, responseStartMs, requestEndMs, socketReused, sentBytesCount,

receivedBytesCount);

// TODO(xunjieli): Fill this with real values.

final RequestFinishedInfo requestFinishedInfo =