Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Side by Side Diff: components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java

Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import static org.chromium.base.CollectionUtil.newHashSet; 7 import static org.chromium.base.CollectionUtil.newHashSet;
8 8
9 import android.os.ConditionVariable; 9 import android.os.ConditionVariable;
10 import android.test.suitebuilder.annotation.SmallTest; 10 import android.test.suitebuilder.annotation.SmallTest;
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 assertNull(metrics.getTtfbMs()); 252 assertNull(metrics.getTtfbMs());
253 253
254 // Check the timing metrics 254 // Check the timing metrics
255 assertNotNull(metrics.getRequestStart()); 255 assertNotNull(metrics.getRequestStart());
256 assertTrue(metrics.getRequestStart().after(startTime) 256 assertTrue(metrics.getRequestStart().after(startTime)
257 || metrics.getRequestStart().equals(startTime)); 257 || metrics.getRequestStart().equals(startTime));
258 MetricsTestUtil.checkNoConnectTiming(metrics); 258 MetricsTestUtil.checkNoConnectTiming(metrics);
259 assertNull(metrics.getSendingStart()); 259 assertNull(metrics.getSendingStart());
260 assertNull(metrics.getSendingEnd()); 260 assertNull(metrics.getSendingEnd());
261 assertNull(metrics.getResponseStart()); 261 assertNull(metrics.getResponseStart());
262 assertNotNull(metrics.getResponseEnd()); 262 assertNotNull(metrics.getRequestEnd());
263 assertTrue(metrics.getResponseEnd().before(endTime) 263 assertTrue(
264 || metrics.getResponseEnd().equals(endTime)); 264 metrics.getRequestEnd().before(endTime) || metrics.getRequestEnd ().equals(endTime));
265 // Entire request should take more than 0 ms 265 // Entire request should take more than 0 ms
266 assertTrue(metrics.getResponseEnd().getTime() - metrics.getRequestStart( ).getTime() > 0); 266 assertTrue(metrics.getRequestEnd().getTime() - metrics.getRequestStart() .getTime() > 0);
267 assertTrue(metrics.getSentBytesCount() == 0); 267 assertTrue(metrics.getSentBytesCount() == 0);
268 assertTrue(metrics.getReceivedBytesCount() == 0); 268 assertTrue(metrics.getReceivedBytesCount() == 0);
269 mTestFramework.mCronetEngine.shutdown(); 269 mTestFramework.mCronetEngine.shutdown();
270 } 270 }
271 271
272 @SmallTest 272 @SmallTest
273 @OnlyRunNativeCronet 273 @OnlyRunNativeCronet
274 @Feature({"Cronet"}) 274 @Feature({"Cronet"})
275 @SuppressWarnings("deprecation") 275 @SuppressWarnings("deprecation")
276 public void testRequestFinishedListenerRemoved() throws Exception { 276 public void testRequestFinishedListenerRemoved() throws Exception {
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 long dnsEnd = -1; 348 long dnsEnd = -1;
349 long connectStart = 4; 349 long connectStart = 4;
350 long connectEnd = 5; 350 long connectEnd = 5;
351 long sslStart = 6; 351 long sslStart = 6;
352 long sslEnd = 7; 352 long sslEnd = 7;
353 long sendingStart = 8; 353 long sendingStart = 8;
354 long sendingEnd = 9; 354 long sendingEnd = 9;
355 long pushStart = 10; 355 long pushStart = 10;
356 long pushEnd = 11; 356 long pushEnd = 11;
357 long responseStart = 12; 357 long responseStart = 12;
358 long responseEnd = 13; 358 long requestEnd = 13;
359 boolean socketReused = true; 359 boolean socketReused = true;
360 long sentBytesCount = 14; 360 long sentBytesCount = 14;
361 long receivedBytesCount = 15; 361 long receivedBytesCount = 15;
362 // Make sure nothing gets reordered inside the Metrics class 362 // Make sure nothing gets reordered inside the Metrics class
363 RequestFinishedInfo.Metrics metrics = new CronetMetrics(requestStart, dn sStart, dnsEnd, 363 RequestFinishedInfo.Metrics metrics = new CronetMetrics(requestStart, dn sStart, dnsEnd,
364 connectStart, connectEnd, sslStart, sslEnd, sendingStart, sendin gEnd, pushStart, 364 connectStart, connectEnd, sslStart, sslEnd, sendingStart, sendin gEnd, pushStart,
365 pushEnd, responseStart, responseEnd, socketReused, sentBytesCoun t, 365 pushEnd, responseStart, requestEnd, socketReused, sentBytesCount ,
366 receivedBytesCount); 366 receivedBytesCount);
367 assertEquals(new Date(requestStart), metrics.getRequestStart()); 367 assertEquals(new Date(requestStart), metrics.getRequestStart());
368 // -1 timestamp should translate to null 368 // -1 timestamp should translate to null
369 assertNull(metrics.getDnsEnd()); 369 assertNull(metrics.getDnsEnd());
370 assertEquals(new Date(dnsStart), metrics.getDnsStart()); 370 assertEquals(new Date(dnsStart), metrics.getDnsStart());
371 assertEquals(new Date(connectStart), metrics.getConnectStart()); 371 assertEquals(new Date(connectStart), metrics.getConnectStart());
372 assertEquals(new Date(connectEnd), metrics.getConnectEnd()); 372 assertEquals(new Date(connectEnd), metrics.getConnectEnd());
373 assertEquals(new Date(sslStart), metrics.getSslStart()); 373 assertEquals(new Date(sslStart), metrics.getSslStart());
374 assertEquals(new Date(sslEnd), metrics.getSslEnd()); 374 assertEquals(new Date(sslEnd), metrics.getSslEnd());
375 assertEquals(new Date(pushStart), metrics.getPushStart()); 375 assertEquals(new Date(pushStart), metrics.getPushStart());
376 assertEquals(new Date(pushEnd), metrics.getPushEnd()); 376 assertEquals(new Date(pushEnd), metrics.getPushEnd());
377 assertEquals(new Date(responseStart), metrics.getResponseStart()); 377 assertEquals(new Date(responseStart), metrics.getResponseStart());
378 assertEquals(new Date(responseEnd), metrics.getResponseEnd()); 378 assertEquals(new Date(requestEnd), metrics.getRequestEnd());
379 assertEquals(socketReused, metrics.getSocketReused()); 379 assertEquals(socketReused, metrics.getSocketReused());
380 assertEquals(sentBytesCount, (long) metrics.getSentBytesCount()); 380 assertEquals(sentBytesCount, (long) metrics.getSentBytesCount());
381 assertEquals(receivedBytesCount, (long) metrics.getReceivedBytesCount()) ; 381 assertEquals(receivedBytesCount, (long) metrics.getReceivedBytesCount()) ;
382 } 382 }
383 } 383 }
OLDNEW
« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/MetricsTestUtil.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698