Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: components/cronet/android/api/src/org/chromium/net/RequestFinishedInfo.java

Issue 2401933002: Rename RequestFinishedInfo.Metrics.getResponseEnd() to getRequestEnd() (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.net; 5 package org.chromium.net;
6 6
7 import android.support.annotation.IntDef; 7 import android.support.annotation.IntDef;
8 import android.support.annotation.Nullable; 8 import android.support.annotation.Nullable;
9 9
10 import java.lang.annotation.Retention; 10 import java.lang.annotation.Retention;
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 * <li>{@link #getRequestStart request start}</li> 60 * <li>{@link #getRequestStart request start}</li>
61 * <li>{@link #getDnsStart DNS start}</li> 61 * <li>{@link #getDnsStart DNS start}</li>
62 * <li>{@link #getDnsEnd DNS end}</li> 62 * <li>{@link #getDnsEnd DNS end}</li>
63 * <li>{@link #getConnectStart connect start}</li> 63 * <li>{@link #getConnectStart connect start}</li>
64 * <li>{@link #getSslStart SSL start}</li> 64 * <li>{@link #getSslStart SSL start}</li>
65 * <li>{@link #getSslEnd SSL end}</li> 65 * <li>{@link #getSslEnd SSL end}</li>
66 * <li>{@link #getConnectEnd connect end}</li> 66 * <li>{@link #getConnectEnd connect end}</li>
67 * <li>{@link #getSendingStart sending start}</li> 67 * <li>{@link #getSendingStart sending start}</li>
68 * <li>{@link #getSendingEnd sending end}</li> 68 * <li>{@link #getSendingEnd sending end}</li>
69 * <li>{@link #getResponseStart response start}</li> 69 * <li>{@link #getResponseStart response start}</li>
70 * <li>{@link #getResponseEnd response end}</li> 70 * <li>{@link #getRequestEnd request end}</li>
71 * </ol> 71 * </ol>
72 * 72 *
73 * Start times are reported as the time when a request started blocking on e vent, not when the 73 * Start times are reported as the time when a request started blocking on e vent, not when the
74 * event actually occurred, with the exception of push start and end. If a m etric is not 74 * event actually occurred, with the exception of push start and end. If a m etric is not
75 * meaningful or not available, including cases when a request finished befo re reaching that 75 * meaningful or not available, including cases when a request finished befo re reaching that
76 * stage, start and end times will be {@code null}. If no time was spent blo cking on an event, 76 * stage, start and end times will be {@code null}. If no time was spent blo cking on an event,
77 * start and end will be the same time. 77 * start and end will be the same time.
78 * 78 *
79 * If the system clock is adjusted during the request, some of the {@link ja va.util.Date} values 79 * If the system clock is adjusted during the request, some of the {@link ja va.util.Date} values
80 * might not match it. Timestamps are recorded using a clock that is guarant eed not to run 80 * might not match it. Timestamps are recorded using a clock that is guarant eed not to run
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 189
190 /** 190 /**
191 * Returns time when the end of the response headers was received. 191 * Returns time when the end of the response headers was received.
192 * @return {@link java.util.Date} representing when the end of the respo nse headers was 192 * @return {@link java.util.Date} representing when the end of the respo nse headers was
193 * received. 193 * received.
194 */ 194 */
195 @Nullable 195 @Nullable
196 public abstract Date getResponseStart(); 196 public abstract Date getResponseStart();
197 197
198 /** 198 /**
199 * Returns time when last byte of response was received. 199 * Returns time when the request finished.
200 * @return {@link java.util.Date} representing when the last byte of the response was 200 * @return {@link java.util.Date} representing when the request finished .
201 * received.
202 */ 201 */
203 @Nullable 202 @Nullable
204 public abstract Date getResponseEnd(); 203 public abstract Date getRequestEnd();
205 204
206 /** 205 /**
207 * Returns whether the socket was reused from a previous request. In HTT P/2 or QUIC, if 206 * Returns whether the socket was reused from a previous request. In HTT P/2 or QUIC, if
208 * streams are multiplexed in a single connection, returns {@code true} for all streams 207 * streams are multiplexed in a single connection, returns {@code true} for all streams
209 * after the first. 208 * after the first.
210 * @return whether this request reused a socket from a previous request. When {@code true}, 209 * @return whether this request reused a socket from a previous request. When {@code true},
211 * DNS, connection, and SSL times will be {@code null}. 210 * DNS, connection, and SSL times will be {@code null}.
212 */ 211 */
213 @Nullable 212 @Nullable
214 public abstract boolean getSocketReused(); 213 public abstract boolean getSocketReused();
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 * If the request failed, returns the same {@link UrlRequestException} provi ded to 341 * If the request failed, returns the same {@link UrlRequestException} provi ded to
343 * {@link UrlRequest.Callback#onFailed}. 342 * {@link UrlRequest.Callback#onFailed}.
344 * 343 *
345 * @return the request's {@link UrlRequestException}, if the request failed 344 * @return the request's {@link UrlRequestException}, if the request failed
346 */ 345 */
347 @Nullable 346 @Nullable
348 public UrlRequestException getException() { 347 public UrlRequestException getException() {
349 return mException; 348 return mException;
350 } 349 }
351 } 350 }
OLDNEW
« no previous file with comments | « no previous file | components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698