Remove Resource::create() to ensure proper subclasses of Resource are created

Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG=652999
Committed: https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0
Cr-Commit-Position: refs/heads/master@{#423454}

[hiroshige, 2016-10-05 07:48:30]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 07:48:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2016-10-05 07:58:02]

Description was changed from

==========
Remove Resource::create() to ensure proper subclasses of Resource are created

BUG=
==========

to

==========
Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG=652999
==========

[hiroshige, 2016-10-05 08:03:18]

hiroshige@chromium.org changed reviewers:
+ mkwst@chromium.org

[hiroshige, 2016-10-05 08:03:19]

PTAL.

https://codereview.chromium.org/2399473002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp (right):

https://codereview.chromium.org/2399473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:145: url,
testImageFilename, WebString::fromUTF8(""),
This is used to set a proper image payload because ImageResource requires the
payload to be decodable.

https://codereview.chromium.org/2399473002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/ResourceFetcherTest.cpp:288: url,
testImageFilename, WebString::fromUTF8(""),
ditto.

[commit-bot: I haz the power, 2016-10-05 08:38:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 08:38:41]

Dry run: Exceeded global retry quota

[hiroshige, 2016-10-05 08:46:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:46:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 10:53:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 10:53:36]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-10-05 12:36:20]

LGTM!

[Nate Chapin, 2016-10-05 18:01:51]

japhet@chromium.org changed reviewers:
+ japhet@chromium.org

[Nate Chapin, 2016-10-05 18:01:51]

LGTM :D

[hiroshige, 2016-10-06 05:03:25]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-10-06 05:03:31]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-10-06 05:03:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 05:13:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 05:13:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hiroshige, 2016-10-06 05:30:39]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2016-10-06 05:30:40]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2399473002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-10-06 05:30:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 06:50:14]

Description was changed from

==========
Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG=652999
==========

to

==========
Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG=652999
==========

[commit-bot: I haz the power, 2016-10-06 06:50:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 06:52:23]

Description was changed from

==========
Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG=652999
==========

to

==========
Remove Resource::create() to ensure proper subclasses of Resource are created

- Resource::create() -> RawResource::create() etc.
- requestResource() + TestResourceFactory -> RawResource::fetch() etc.

BUG=652999

Committed: https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0
Cr-Commit-Position: refs/heads/master@{#423454}
==========

[commit-bot: I haz the power, 2016-10-06 06:52:24]

Patchset 3 (id:??) landed as
https://crrev.com/1ce92d73d9adf9b97c1e7e207ea52867b32621e0
Cr-Commit-Position: refs/heads/master@{#423454}