Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: third_party/WebKit/Source/core/fetch/ResourceTest.cpp

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ResourceTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ResourceTest.cpp b/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
index f0a77a9c9d097b8b299f2a5cafc8b616b953c9bc..e55a87fd2bed0360124e9dd3d0fff2e6cfa97dad 100644
--- a/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/ResourceTest.cpp
@@ -5,6 +5,7 @@
#include "core/fetch/Resource.h"
#include "core/fetch/MemoryCache.h"
+#include "core/fetch/RawResource.h"
#include "platform/SharedBuffer.h"
#include "platform/network/ResourceRequest.h"
#include "platform/network/ResourceResponse.h"
@@ -44,7 +45,7 @@ ResourceResponse createTestResourceResponse() {
void createTestResourceAndSetCachedMetadata(const ResourceResponse& response) {
const char testData[] = "test data";
Resource* resource =
- Resource::create(ResourceRequest(response.url()), Resource::Raw);
+ RawResource::create(ResourceRequest(response.url()), Resource::Raw);
resource->setResponse(response);
resource->cacheHandler()->setCachedMetadata(
100, testData, sizeof(testData), CachedMetadataHandler::SendToPlatform);
@@ -75,7 +76,7 @@ TEST(ResourceTest, RevalidateWithFragment) {
ResourceResponse response;
response.setURL(url);
response.setHTTPStatusCode(200);
- Resource* resource = Resource::create(url, Resource::Raw);
+ Resource* resource = RawResource::create(url, Resource::Raw);
resource->responseReceived(response, nullptr);
resource->finish();

Powered by Google App Engine
This is Rietveld 408576698