third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp - Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)

Patch Set: Rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

index 745036a4cf56f3586a19b52e29144c95dc97e656..587b47dfa71b4c33b31983d22f7e361b5a9b58c4 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

@@ -613,7 +613,7 @@ TEST_F(FrameFetchContextDisplayedCertificateErrorsTest,

ResourceResponse response;

response.setURL(url);

response.setHasMajorCertificateErrors(true);

- Resource* resource = Resource::create(resourceRequest, Resource::Image);

+ Resource* resource = ImageResource::create(resourceRequest);

resource->setResponse(response);

fetchContext->dispatchDidLoadResourceFromMemoryCache(

createUniqueIdentifier(), resource, WebURLRequest::FrameTypeNone,

« no previous file with comments | « third_party/WebKit/Source/core/frame/SubresourceIntegrityTest.cpp ('k') | no next file » | no next file with comments »