Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Side by Side Diff: third_party/WebKit/Source/core/fetch/FontResource.h

Issue 2399473002: Remove Resource::create() to ensure proper subclasses of Resource are created (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef FontResource_h 26 #ifndef FontResource_h
27 #define FontResource_h 27 #define FontResource_h
28 28
29 #include "core/CoreExport.h"
29 #include "core/fetch/Resource.h" 30 #include "core/fetch/Resource.h"
30 #include "core/fetch/ResourceClient.h" 31 #include "core/fetch/ResourceClient.h"
31 #include "platform/Timer.h" 32 #include "platform/Timer.h"
32 #include "platform/fonts/FontOrientation.h" 33 #include "platform/fonts/FontOrientation.h"
33 #include "platform/heap/Handle.h" 34 #include "platform/heap/Handle.h"
34 #include <memory> 35 #include <memory>
35 36
36 namespace blink { 37 namespace blink {
37 38
38 class FetchRequest; 39 class FetchRequest;
39 class ResourceFetcher; 40 class ResourceFetcher;
40 class FontPlatformData; 41 class FontPlatformData;
41 class FontCustomPlatformData; 42 class FontCustomPlatformData;
42 class FontResourceClient; 43 class FontResourceClient;
43 44
44 class FontResource final : public Resource { 45 class CORE_EXPORT FontResource final : public Resource {
45 public: 46 public:
46 using ClientType = FontResourceClient; 47 using ClientType = FontResourceClient;
47 48
48 static FontResource* fetch(FetchRequest&, ResourceFetcher*); 49 static FontResource* fetch(FetchRequest&, ResourceFetcher*);
49 ~FontResource() override; 50 ~FontResource() override;
50 51
51 void didAddClient(ResourceClient*) override; 52 void didAddClient(ResourceClient*) override;
52 53
53 void setRevalidatingRequest(const ResourceRequest&) override; 54 void setRevalidatingRequest(const ResourceRequest&) override;
54 55
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 return client->getResourceClientType() == FontType; 105 return client->getResourceClientType() == FontType;
105 } 106 }
106 ResourceClientType getResourceClientType() const final { return FontType; } 107 ResourceClientType getResourceClientType() const final { return FontType; }
107 virtual void fontLoadShortLimitExceeded(FontResource*) {} 108 virtual void fontLoadShortLimitExceeded(FontResource*) {}
108 virtual void fontLoadLongLimitExceeded(FontResource*) {} 109 virtual void fontLoadLongLimitExceeded(FontResource*) {}
109 }; 110 };
110 111
111 } // namespace blink 112 } // namespace blink
112 113
113 #endif 114 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698